Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move package depends to suggest #798

Merged
merged 12 commits into from
Sep 30, 2024
Merged

Move package depends to suggest #798

merged 12 commits into from
Sep 30, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Sep 27, 2024

Description

This PR closes #796.

It makes the {future} packages and {progressr} suggests instead of depends, and only uses their functionality if available.

Probably the same could be done for {futile.logger} but that would be a bit more complicated as its functions are called a lot more than the ones moved here.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@sbfnk sbfnk changed the title Move to suggest Move package depends to suggest Sep 27, 2024
NEWS.md Outdated Show resolved Hide resolved
seabbs
seabbs previously approved these changes Sep 30, 2024
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

Co-authored-by: Sam Abbott <[email protected]>
seabbs
seabbs previously approved these changes Sep 30, 2024
@seabbs seabbs added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 2fb6f1a Sep 30, 2024
9 checks passed
@seabbs seabbs deleted the move-to-suggest branch September 30, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies
2 participants